regression(ABAC): missing room icon on abac rooms table #37868

MartinSchoeler · 2025-12-18T19:05:49Z

Proposed changes (including videos or screenshots)

Issue(s)

ABAC-106

Steps to test or reproduce

Further comments

Summary by CodeRabbit

New Features
- Added visual room icons to the admin ABAC rooms table, shown before each room name to aid identification.
Style / UI
- First-column layout updated to include horizontal spacing and truncated text for consistent alignment and improved readability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

dionisio-bot · 2025-12-18T19:05:53Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-18T19:05:54Z

⚠️ No Changeset found

Latest commit: 3858e26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-18T19:05:57Z

Walkthrough

Added a RoomIcon to the ABAC rooms table's first column and applied truncation and horizontal margin styling; no data or navigation logic was changed. (47 words)

Changes

Cohort / File(s)	Summary
ABAC Rooms Table UI `apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsPage.tsx`	Imported `RoomIcon` and rendered it inside the first table cell before the room label (`room.fname

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Review focus: UI rendering line in RoomsPage.tsx and any style/classname usage for truncation/margins.

Possibly related PRs

chore: add new icons to abac rooms #37424 — Changes around room icon rendering/selection that affect ABAC icon surface.
regression: ABAC table & form fixes #37782 — Other modifications to ABAC/ABACRoomsTab/RoomsPage.tsx touching row presentation and truncation.

Suggested reviewers

KevLehman
tassoevan

Poem

🐰 A tiny icon hops near the name,
Nestled tidy, never the same,
Rows now smile with a brand-new face,
Small and spry in their little space.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'regression(ABAC): missing room icon on abac rooms table' clearly and specifically describes the main change: adding a missing room icon to the ABAC rooms table UI.
Linked Issues check	✅ Passed	The code changes directly address the linked issue ABAC-106 by adding RoomIcon rendering to the ABAC rooms table, matching the requirement to display room icons on the table rows.
Out of Scope Changes check	✅ Passed	All changes are scoped to the RoomsPage.tsx component and directly related to restoring the missing room icon display in the ABAC rooms table, with no unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch regression/abac-room-icon

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6337c9e and 3858e26.

📒 Files selected for processing (1)

apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsPage.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsPage.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-18T19:37:16Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	-507B
queue-worker-service	132MiB	132MiB	-753B
ddp-streamer-service	126MiB	126MiB	-529B
account-service	113MiB	113MiB	+110B
authorization-service	111MiB	111MiB	-850B
stream-hub-service	111MiB	111MiB	-1B
presence-service	111MiB	111MiB	+391B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 06:10", "12/20 07:41 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 26 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37868
Baseline: develop
Timestamp: 2025-12-20 07:41:19 UTC
Historical data points: 26

Updated: Sat, 20 Dec 2025 07:41:20 GMT

codecov · 2025-12-18T20:14:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.76%. Comparing base (5836726) to head (3858e26).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37868      +/-   ##
===========================================
+ Coverage    67.69%   67.76%   +0.07%     
===========================================
  Files         3476     3476              
  Lines       113895   113895              
  Branches     20956    20956              
===========================================
+ Hits         77098    77178      +80     
+ Misses       34609    34519      -90     
- Partials      2188     2198      +10

Flag	Coverage Δ
e2e	`57.15% <ø> (-0.01%)`	⬇️
e2e-api	`44.97% <ø> (+0.90%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…7868)

regression: missing room icon on abac rooms table

6337c9e

MartinSchoeler changed the title ~~regression: missing room icon on abac rooms table~~ regression(ABAC): missing room icon on abac rooms table Dec 18, 2025

MartinSchoeler added this to the 7.14.0 milestone Dec 18, 2025

MartinSchoeler marked this pull request as ready for review December 18, 2025 21:05

MartinSchoeler requested a review from a team as a code owner December 18, 2025 21:05

tassoevan approved these changes Dec 19, 2025

View reviewed changes

tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2025

kodiakhq bot and others added 5 commits December 20, 2025 03:38

Merge branch 'develop' into regression/abac-room-icon

86f0e47

Merge branch 'develop' into regression/abac-room-icon

dc50381

Merge branch 'develop' into regression/abac-room-icon

27f1352

Merge branch 'develop' into regression/abac-room-icon

7f50a87

Merge branch 'develop' into regression/abac-room-icon

3858e26

kodiakhq bot merged commit 76d263e into develop Dec 20, 2025
83 of 89 checks passed

kodiakhq bot deleted the regression/abac-room-icon branch December 20, 2025 08:38

gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026

regression(ABAC): missing room icon on abac rooms table (RocketChat#3…

63a5a26

…7868)

dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression(ABAC): missing room icon on abac rooms table #37868

regression(ABAC): missing room icon on abac rooms table #37868

Uh oh!

MartinSchoeler commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

regression(ABAC): missing room icon on abac rooms table #37868

regression(ABAC): missing room icon on abac rooms table #37868

Uh oh!

Conversation

MartinSchoeler commented Dec 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

codecov bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MartinSchoeler commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Dec 18, 2025 •

edited

Loading

changeset-bot bot commented Dec 18, 2025 •

edited

Loading

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

codecov bot commented Dec 18, 2025 •

edited

Loading